NicoK commented on a change in pull request #10113: [FLINK-13749][client] Make 
PackagedProgram respect classloading policy
URL: https://github.com/apache/flink/pull/10113#discussion_r345237843
 
 

 ##########
 File path: 
flink-tests/src/test/java/org/apache/flink/test/classloading/jar/ClassLoadingPolicyProgram.java
 ##########
 @@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.test.classloading.jar;
+
+import java.io.File;
+import java.net.URL;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * A simple program that verifies the classloading policy by ensuring the 
resource loaded is under the specified
+ * directory.
+ **/
+public class ClassLoadingPolicyProgram {
+
+       public static void main(String[] args) throws Exception {
+               if (args.length < 2) {
+                       throw new IllegalArgumentException("Missing 
parameters");
 
 Review comment:
   Some more details may be nice, like this?
   ```suggestion
                        throw new IllegalArgumentException("Missing parameters. 
Expected: <resourceName> <expectedResourceDir>");
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to