NicoK commented on a change in pull request #10113: [FLINK-13749][client] Make
PackagedProgram respect classloading policy
URL: https://github.com/apache/flink/pull/10113#discussion_r345241226
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java
##########
@@ -104,13 +105,15 @@
* @param jarFile The jar file which contains the plan.
* @param classpaths Additional classpath URLs needed by the
Program.
* @param entryPointClassName Name of the class which generates the
plan. Overrides the class defined
- * in the jar file manifest
+ * in the jar file manifest.
+ * @param configuration Flink configuration which affects the
classloading policy of the Program execution.
* @param args Optional. The arguments used to create
the pact plan, depend on
* implementation of the pact plan. See
getDescription().
* @throws ProgramInvocationException This invocation is thrown if the
Program can't be properly loaded. Causes
* may be a missing / wrong class or
manifest files.
*/
- private PackagedProgram(@Nullable File jarFile, List<URL> classpaths,
@Nullable String entryPointClassName, String... args) throws
ProgramInvocationException {
+ private PackagedProgram(@Nullable File jarFile, List<URL> classpaths,
@Nullable String entryPointClassName,
+ Configuration
configuration, String... args) throws ProgramInvocationException {
Review comment:
please put each parameter on a single line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
