NicoK commented on a change in pull request #10113: [FLINK-13749][client] Make
PackagedProgram respect classloading policy
URL: https://github.com/apache/flink/pull/10113#discussion_r345241483
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java
##########
@@ -140,7 +143,8 @@ private PackagedProgram(@Nullable File jarFile, List<URL>
classpaths, @Nullable
// now that we have an entry point, we can extract the nested
jar files (if any)
this.extractedTempLibraries = jarFileUrl == null ?
Collections.emptyList() : extractContainedLibraries(jarFileUrl);
this.classpaths = classpaths;
- this.userCodeClassLoader =
ClientUtils.buildUserCodeClassLoader(getAllLibraries(), classpaths,
getClass().getClassLoader());
+ this.userCodeClassLoader =
ClientUtils.buildUserCodeClassLoader(getAllLibraries(), classpaths,
+ getClass().getClassLoader(), configuration);
Review comment:
please put each parameter on a single line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
