pnowojski commented on a change in pull request #10177: [FLINK-14747] Fix
performance regression with latest changes to Mailbox
URL: https://github.com/apache/flink/pull/10177#discussion_r346188685
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java
##########
@@ -240,23 +247,22 @@ private void checkIsMailboxThread() {
}
private void checkPutStateConditions() {
- final State state = this.state;
- if (this.state != OPEN) {
+ if (state != OPEN) {
throw new IllegalStateException("Mailbox is in state "
+ state + ", but is required to be in state " +
OPEN + " for put operations.");
}
}
private void checkTakeStateConditions() {
- final State state = this.state;
- if (this.state == CLOSED) {
+ if (state == CLOSED) {
throw new IllegalStateException("Mailbox is in state "
+ state + ", but is required to be in state " +
OPEN + " or " + QUIESCED + " for take
operations.");
}
}
@Override
public void quiesce() {
+ checkIsMailboxThread();
Review comment:
Can you move the unrelated changes to a separate `[hotfix]` commit? (also
fixing the typo for example)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
