pnowojski commented on a change in pull request #10177: [FLINK-14747] Fix
performance regression with latest changes to Mailbox
URL: https://github.com/apache/flink/pull/10177#discussion_r346186505
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java
##########
@@ -149,13 +144,17 @@ public boolean hasMail() {
@Override
public boolean createBatch() {
checkIsMailboxThread();
+ if (!hasNewMail) {
+ return !batch.isEmpty();
Review comment:
Are we allowing to call `createBatch` multiple times? Does it make sense, or
shouldn't this be a `checkState(batch.isEmpty())`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
