pnowojski commented on a change in pull request #10177: [FLINK-14747] Fix 
performance regression with latest changes to Mailbox
URL: https://github.com/apache/flink/pull/10177#discussion_r346192517
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java
 ##########
 @@ -80,6 +80,11 @@
         */
        private final Deque<Mail> batch = new ArrayDeque<>();
 
+       /**
+        * Performance optimization where hasNewMail == !queue.isEmpty().
 
 Review comment:
   comment that it doesn't take the `batch` into account? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to