wuchong commented on a change in pull request #10224:
[FLINK-14716][table-planner-blink] Cooperate computed column with push down
rules
URL: https://github.com/apache/flink/pull/10224#discussion_r347262004
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalTableSourceScan.scala
##########
@@ -107,7 +107,8 @@ object FlinkLogicalTableSourceScan {
tableSourceTable != null
}
- def create(cluster: RelOptCluster, relOptTable: FlinkRelOptTable):
FlinkLogicalTableSourceScan = {
+ def create(cluster: RelOptCluster, relOptTable: FlinkPreparingTableBase)
+ : FlinkLogicalTableSourceScan = {
val table = relOptTable.unwrap(classOf[Table])
Review comment:
We should update this like what you do in
`FlinkLogicalTableSourceScan#create`. As `relOptTable` doesn't wrap any `Table`
more, the unwrapped `table` will always be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
