wuchong commented on a change in pull request #10224:
[FLINK-14716][table-planner-blink] Cooperate computed column with push down
rules
URL: https://github.com/apache/flink/pull/10224#discussion_r347709661
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/plan/FlinkCalciteCatalogReaderTest.java
##########
@@ -73,6 +73,9 @@ public void testGetCatalogSchemaTable() {
catalogReader.getTable(Collections.singletonList(tableMockName));
fail("Unexpected exception");
} catch (NullPointerException npe) {
+ // We have a mocked CatalogSchemaTable which does not
have implementation,
Review comment:
So what's the purpose of this test? To test an expected NPE?
From the test method name and the original implementation, I think it want
to test the expected table result.
IMO we shouldn't mock the `CatalogSchemaTable`, we can create a concrete
instance of `CatalogSchemaTable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
