wuchong commented on a change in pull request #10224:
[FLINK-14716][table-planner-blink] Cooperate computed column with push down
rules
URL: https://github.com/apache/flink/pull/10224#discussion_r347706114
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/PushProjectIntoTableSourceScanRule.scala
##########
@@ -101,7 +101,7 @@ class PushProjectIntoTableSourceScanRule extends
RelOptRule(
.getTypeFactory
.asInstanceOf[FlinkTypeFactory]
val newSourceRowType = TableSourceUtil.getSourceRowType(flinkTypeFactory,
- oldTableSource.getTableSchema,
+ tableSourceTable.catalogTable.getSchema,
Review comment:
I really doubt this. The source row type should not use
`catalogTable#tableSchema` which may contain computed column. That's why I was
suggesting to put the row type logic in `TableSourceTable`. This is very easy
to make mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
