WeiZhong94 commented on a change in pull request #10103:
[FLINK-14506][python][build] Improve the release script for Python API release
package
URL: https://github.com/apache/flink/pull/10103#discussion_r347295740
##########
File path: flink-python/dev/lint-python.sh
##########
@@ -435,6 +467,27 @@ function get_all_supported_checks() {
IFS=$_OLD_IFS
}
+# get all supported install components functions
+function get_all_supported_install_components() {
+ _OLD_IFS=$IFS
+ IFS=$'\n'
+ for fun in $(declare -F); do
+ if echo "${fun:11}" | grep -e "^install_" &>/dev/null; then
+ SUPPORT_INSTALL_COMPONENTS+=("${fun:19}")
+ fi
+ done
+ IFS=$_OLD_IFS
+ # we don't need to expose "install_wget" to user.
+ local DELETE_COMPONENTS=("wget")
+ local REAL_COMPONENTS=()
+ for (( i = 0; i < ${#SUPPORT_INSTALL_COMPONENTS[@]}; i++)); do
+ if ! echo "${DELETE_COMPONENTS[@]}" | grep -w
"${SUPPORT_INSTALL_COMPONENTS[i]}" &>/dev/null; then
Review comment:
extract this logic to a function like "contains_element"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
