WeiZhong94 commented on a change in pull request #10103:
[FLINK-14506][python][build] Improve the release script for Python API release
package
URL: https://github.com/apache/flink/pull/10103#discussion_r347365531
##########
File path: flink-python/dev/lint-python.sh
##########
@@ -268,6 +292,14 @@ function install_sphinx() {
fi
}
+function need_install_component() {
+ if echo "${SUPPORT_INSTALL_COMPONENTS[@]}" | grep -w "$1" &>/dev/null; then
+ echo 1
Review comment:
Using "true" or "false" can make it more clear. See
https://stackoverflow.com/questions/2953646/how-can-i-declare-and-use-boolean-variables-in-a-shell-script
. Make it return a boolean value is also a good choice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
