WeiZhong94 commented on a change in pull request #10103: [FLINK-14506][python][build] Improve the release script for Python API release package URL: https://github.com/apache/flink/pull/10103#discussion_r347294765
########## File path: flink-python/dev/lint-python.sh ########## @@ -589,16 +642,34 @@ get_all_supported_checks EXCLUDE_CHECKS="" INCLUDE_CHECKS="" + +SUPPORT_INSTALL_COMPONENTS=() +# search all supported install functions and put them into SUPPORT_INSTALL_COMPONENTS array +get_all_supported_install_components + +INSTALL_COMPONENTS="" # parse_opts USAGE=" usage: $0 [options]$ -h print this help message and exit -f force to exec from the progress of installing environment +-s install environment with specified components which include basic,py_env,tox,flake8,sphinx,all + e.g. -s basic + then the env will only install basic component. + e.g. -s py_env + then the env will install basic component with python env(3.5,3.6,3.7). + e.g. -s tox,flake8 + then the env will install basic component with tox,flake8. + e.g. -s all + then the env will install all components such as python env,tox,flake8,sphinx etc. + note: + this option is for installing environment components without checks, so don't use this option Review comment: "installing environment components without checks" is misleading here. How about make it more clear, such as "This option is used to install environment components and will skip all subsequent checks, so do not use this option with -e,-i simultaneously"? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
