wuchong commented on a change in pull request #10224: [FLINK-14716][table-planner-blink] Cooperate computed column with push down rules URL: https://github.com/apache/flink/pull/10224#discussion_r347767780
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/catalog/CatalogSchemaTable.java ########## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.catalog; + +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.api.TableSchema; +import org.apache.flink.table.catalog.CatalogBaseTable; +import org.apache.flink.table.catalog.ConnectorCatalogTable; +import org.apache.flink.table.catalog.ObjectIdentifier; +import org.apache.flink.table.factories.TableFactory; +import org.apache.flink.table.planner.calcite.FlinkTypeFactory; +import org.apache.flink.table.planner.plan.stats.FlinkStatistic; +import org.apache.flink.table.planner.sources.TableSourceUtil; +import org.apache.flink.table.types.DataType; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.TimestampKind; +import org.apache.flink.table.types.logical.TimestampType; + +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rel.type.RelDataTypeFactory; +import org.apache.calcite.schema.TemporalTable; +import org.apache.calcite.schema.impl.AbstractTable; + +import javax.annotation.Nullable; + +import java.util.List; +import java.util.Optional; + +/** + * Represents a wrapper for {@link CatalogBaseTable} in {@link org.apache.calcite.schema.Schema}. + * + * <p>This table would be converted to + * {@link org.apache.flink.table.planner.plan.schema.FlinkPreparingTableBase} + * based on its internal source type during sql-to-rel conversion. + * + * <p>See + * {@link org.apache.flink.table.planner.plan.FlinkCalciteCatalogReader#getTable(List)} + * for details. + */ +public class CatalogSchemaTable extends AbstractTable implements TemporalTable { + //~ Instance fields -------------------------------------------------------- + + private final ObjectIdentifier tableIdentifier; + private final CatalogBaseTable catalogBaseTable; + private final FlinkStatistic statistic; + private final boolean isStreamingMode; + private final boolean isTemporary; + + @Nullable + private final TableFactory tableFactory; + + //~ Constructors ----------------------------------------------------------- + + /** + * Create a CatalogSchemaTable instance. + * + * @param tableIdentifier Table identifier + * @param catalogBaseTable CatalogBaseTable instance which exists in the catalog + * @param statistic Table statistics + * @param tableFactory Optional table factory to create the table source + * @param isStreaming If the table is for streaming mode + * @param isTemporary If the table is temporary + */ + public CatalogSchemaTable( + ObjectIdentifier tableIdentifier, + CatalogBaseTable catalogBaseTable, + FlinkStatistic statistic, + @Nullable TableFactory tableFactory, + boolean isStreaming, + boolean isTemporary) { + this.tableIdentifier = tableIdentifier; + this.catalogBaseTable = catalogBaseTable; + this.statistic = statistic; + this.tableFactory = tableFactory; + this.isStreamingMode = isStreaming; + this.isTemporary = isTemporary; + } + + //~ Methods ---------------------------------------------------------------- + + public Optional<TableFactory> getTableFactory() { + return Optional.ofNullable(tableFactory); + } + + public ObjectIdentifier getTableIdentifier() { + return tableIdentifier; + } + + public CatalogBaseTable getCatalogTable() { + return catalogBaseTable; + } + + public boolean isTemporary() { + return isTemporary; + } + + public boolean isStreamingMode() { + return isStreamingMode; + } + + @Override + public RelDataType getRowType(RelDataTypeFactory typeFactory) { + return getRowType(typeFactory, catalogBaseTable, isStreamingMode); + } + + @Override + public FlinkStatistic getStatistic() { + return statistic; + } + + private static RelDataType getRowType(RelDataTypeFactory typeFactory, + CatalogBaseTable catalogBaseTable, + boolean isStreamingMode) { + final FlinkTypeFactory flinkTypeFactory = (FlinkTypeFactory) typeFactory; + TableSchema tableSchema = catalogBaseTable.getSchema(); + final DataType[] fieldDataTypes = tableSchema.getFieldDataTypes(); + if (!isStreamingMode + && catalogBaseTable instanceof ConnectorCatalogTable + && ((ConnectorCatalogTable) catalogBaseTable).getTableSource().isPresent()) { + // If the table source is bounded, materialize the time attributes to normal TIMESTAMP type. + // Now for ConnectorCatalogTable, there is no way to + // deduce if it is bounded in the table environment, so the data types in TableSchema + // always patched with TimeAttribute. + // See ConnectorCatalogTable#calculateSourceSchema + // for details. + + // Remove the patched time attributes type to let the TableSourceTable handle it. + // We should remove this logic if the isBatch flag in ConnectorCatalogTable is fixed. + // TODO: Fix FLINK-14844. + for (int i = 0; i < fieldDataTypes.length; i++) { + LogicalType lt = fieldDataTypes[i].getLogicalType(); + if (lt instanceof TimestampType + && (((TimestampType) lt).getKind() == TimestampKind.PROCTIME + || ((TimestampType) lt).getKind() == TimestampKind.ROWTIME)) { + int precision = ((TimestampType) lt).getPrecision(); + fieldDataTypes[i] = DataTypes.TIMESTAMP(precision); Review comment: `fieldDataTypes` is never used. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
