xintongsong commented on a change in pull request #10161:
[FLINK-13986][runtime] Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r347880334
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -242,7 +242,11 @@ private static FlinkInternalMemory
deriveInternalMemoryFromTotalFlinkMemory(
} else {
managedMemorySize =
deriveManagedMemoryAbsoluteOrWithFraction(config, totalFlinkMemorySize);
}
- shuffleMemorySize =
deriveShuffleMemoryWithFraction(config, totalFlinkMemorySize);
+ if (isUsingLegacyShuffleConfigs(config)) {
Review comment:
I think I discovered this problem through a test case failure, but I do not
remember which.
I'll add another on in `TaskExecutorResourceUtilsTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
