xintongsong commented on a change in pull request #10161:
[FLINK-13986][runtime] Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r347881912
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -163,7 +162,7 @@
/**
* Amount of memory to be allocated by the task manager's memory
manager. If not
- * set, a relative fraction will be allocated, as defined by {@link
#LEGACY_MANAGED_MEMORY_FRACTION}.
+ * set, a relative fraction will be allocated, as defined by {@link
#MANAGED_MEMORY_FRACTION}.
Review comment:
I don't think so. The semantic has changed. I think making it a deprecated
key may mislead the user to overlook the semantic change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
