xintongsong commented on a change in pull request #10161:
[FLINK-13986][runtime] Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r348441866
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -539,20 +544,21 @@ private void requestYarnContainer() {
RM_REQUEST_PRIORITY);
}
- private ContainerLaunchContext createTaskExecutorLaunchContext(Resource
resource, String containerId, String host)
- throws Exception {
+ private ContainerLaunchContext createTaskExecutorLaunchContext(
+ TaskExecutorResourceSpec tmResourceSpec,
Review comment:
True, we should use the class field directly.
We cannot adjust `taskExecutorResourceSpec` to `resource.getMemory()`.
Because we generate profiles for pending slots before containers are allocated,
based on the memory sizes derived from configuration. If we then change the
`taskExecutorResourceSpec` to `resource.getMemory()`, it may generated
different JVM parameters and dynamic configurations, of which the latter will
be used for generating slot profiles on the TM side. As a result, we may have
different slot profiles for pending slots on RM side and actual slots on TM
side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
