azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime]
Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r348468685
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -539,20 +544,21 @@ private void requestYarnContainer() {
RM_REQUEST_PRIORITY);
}
- private ContainerLaunchContext createTaskExecutorLaunchContext(Resource
resource, String containerId, String host)
- throws Exception {
+ private ContainerLaunchContext createTaskExecutorLaunchContext(
+ TaskExecutorResourceSpec tmResourceSpec,
Review comment:
In future, we probably can take this into account with
`PendingTaskExecutorResource` in FLIP-56 where we could try to match it with
the registration by some id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
