azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r350310089
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java
##########
@@ -259,6 +269,7 @@ public static TaskManagerConfiguration
fromConfiguration(Configuration configura
return new TaskManagerConfiguration(
numberSlots,
+
taskExecutorResourceSpec.getDefaultSlotResourceProfile(),
Review comment:
I meant not sharing `TaskExecutorResourceSpec` between
`TaskManagerServicesConfiguration` and `TaskManagerConfiguration` but
calculating them inside `fromConfiguration` to avoid changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
