azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile URL: https://github.com/apache/flink/pull/10146#discussion_r351844776
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceSpecBuilder.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.clusterframework; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.MemorySize; +import org.apache.flink.configuration.TaskManagerOptions; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * Builder for {@link TaskExecutorResourceSpec}. + */ +public class TaskExecutorResourceSpecBuilder { + + private final Configuration configuration; + + private MemorySize totalProcessMemory = null; + + private TaskExecutorResourceSpecBuilder(final Configuration configuration) { + this.configuration = new Configuration(checkNotNull(configuration)); + } + + public static TaskExecutorResourceSpecBuilder newBuilder(final Configuration configuration) { + return new TaskExecutorResourceSpecBuilder(configuration); + } + + public TaskExecutorResourceSpecBuilder withTotalProcessMemory(MemorySize totalProcessMemory) { + this.totalProcessMemory = totalProcessMemory; + return this; + } + + public TaskExecutorResourceSpec build() { + if (totalProcessMemory != null) { + configuration.setString(TaskManagerOptions.TOTAL_PROCESS_MEMORY, totalProcessMemory.toString()); Review comment: we do not duplicate `configuration`? I would simply do this for each call of `#withXXX` instead of keeping `totalProcessMemory`: ``` public TaskExecutorResourceSpecBuilder withTotalProcessMemory(MemorySize totalProcessMemory) { changeConfigurationOption( TaskManagerOptions.TOTAL_PROCESS_MEMORY, totalProcessMemory.toString()); return this; } public <T> void changeConfigurationOption( final ConfigOption<T> option, final T newValue) { final Configuration copiedConfig = new Configuration(configuration); copiedConfig.set(option, newValue); configuration = copiedConfig; } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
