azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r351850281
##########
File path:
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerTest.java
##########
@@ -275,7 +275,10 @@ protected void closeTaskManagerConnection(ResourceID
resourceID, Exception cause
ContainerSpecification containerSpecification = new
ContainerSpecification();
MemorySize totalProcessMemory = MemorySize.parse("2g");
- TaskExecutorResourceSpec spec =
TaskExecutorResourceUtils.resourceSpecFromConfig(flinkConfig,
totalProcessMemory);
+ TaskExecutorResourceSpec spec =
TaskExecutorResourceSpecBuilder
+ .newBuilder(flinkConfig)
Review comment:
I would do `TaskExecutorResourceSpecBuilder` package internal class returned
by `TaskExecutorResourceUtils#newResourceSpecFromConfigBuilder` to have
everything in `TaskExecutorResourceUtils`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
