TisonKun commented on a change in pull request #10193: [FLINK-13938][yarn] Use
pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r350545500
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
##########
@@ -93,8 +114,8 @@ private void
deployPerjob(YarnConfigOptions.UserJarInclusion userJarInclusion) t
true)) {
yarnClusterDescriptor.setLocalJarPath(new
Path(flinkUberjar.getAbsolutePath()));
-
yarnClusterDescriptor.addShipFiles(Arrays.asList(flinkLibFolder.listFiles()));
-
yarnClusterDescriptor.addShipFiles(Arrays.asList(flinkShadedHadoopDir.listFiles()));
+
yarnClusterDescriptor.addShipFiles(Collections.singletonList(flinkLibFolder));
Review comment:
I don't stick to revert this but want to know that, we don't change anything
by this diff right? IIRC Flink will iterate over a directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
