pnowojski commented on a change in pull request #10247:
[FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1…
URL: https://github.com/apache/flink/pull/10247#discussion_r350666032
##########
File path: docs/monitoring/metrics.md
##########
@@ -1139,6 +1139,12 @@ Metrics related to data exchange between task executors
using netty network comm
<td>An estimate of the output buffers usage.</td>
<td>Gauge</td>
</tr>
+ <tr>
+ <td rowspan="1">Shuffle.Netty.BackPressure</td>
Review comment:
I think this should be moved out from `Netty` scope. This metric will work
for all of the shuffle services, not only the netty so:
- could you create a separate table for the `isBackPressured` metric, titled
`Common shuffle service metrics`, with a single metric inside
`Shuffle.BackPressure.isBackPressured`?
- adjust the code accordingly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
