pnowojski commented on a change in pull request #10247:
[FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1…
URL: https://github.com/apache/flink/pull/10247#discussion_r351129443
##########
File path: docs/monitoring/metrics.md
##########
@@ -1139,6 +1139,12 @@ Metrics related to data exchange between task executors
using netty network comm
<td>An estimate of the output buffers usage.</td>
<td>Gauge</td>
</tr>
+ <tr>
+ <td rowspan="1">Shuffle.Netty.BackPressure</td>
Review comment:
It shouldn't be `Shuffle.Netty.Backpressure`, because `Shuffle.Netty`
contains netty specific metrics. Since `Task#isBackPressured` method is using
`ResultPartitionWriter#getAvailableFuture`, which is part of the shuffle API,
`Task#isBackPressured` will work automatically for every shuffle service, not
only netty.
By the way, I'm not sure if I was clear enough about moving this to a
separate table. I meant currently you added `isBackPressured` metric to the:
https://ci.apache.org/projects/flink/flink-docs-stable/monitoring/metrics.html#default-shuffle-service
> Default shuffle service
section, while because of the above reasoning, it should be in a new section
and a new table (currently with only single entry) titled:
> Common shuffle service metrics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
