pnowojski commented on a change in pull request #10247: 
[FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1…
URL: https://github.com/apache/flink/pull/10247#discussion_r350664850
 
 

 ##########
 File path: docs/monitoring/metrics.md
 ##########
 @@ -1117,7 +1117,7 @@ Metrics related to data exchange between task executors 
using netty network comm
       <td>Gauge</td>
     </tr>
     <tr>
-      <th rowspan="8">Task</th>
+      <th rowspan="9">Task</th>
 
 Review comment:
   nit: **optional** side issue, could you merge both `Task` cells together 
(separate commit)? They are currently duplicated 
https://ci.apache.org/projects/flink/flink-docs-release-1.9/monitoring/metrics.html#default-shuffle-service
   probably it's enough to change `rowspan=8` here to `16`, and remove the 
duplicated `<th rowspan="8"><strong>Task</strong></th>` from around L1167

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to