zhuzhurk commented on a change in pull request #10309: [FLINK-14909][runtime]
Let tasks get scheduled in topological order when possible
URL: https://github.com/apache/flink/pull/10309#discussion_r351104548
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/SchedulingStrategy.java
##########
@@ -40,9 +40,9 @@
/**
* Called whenever vertices need to be restarted (due to task failure).
*
- * @param verticesToRestart The tasks need to be restarted
+ * @param verticesToRestart The tasks to be restarted, topologically
sorted
*/
- void restartTasks(Set<ExecutionVertexID> verticesToRestart);
+ void restartTasks(List<ExecutionVertexID> verticesToRestart);
Review comment:
This makes it easier for vertices to `#allocateSlotsAndDeploy` vertices in
topological order.
But you remind me that we can do it in a different way that do not change
this interface: having a set of vertices to schedule, iterate over all the
vertices in the topology in topological order to create an ordered list, and
then invoke `#allocateSlotsAndDeploy` on the list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
