zhuzhurk commented on a change in pull request #10309: [FLINK-14909][runtime]
Let tasks get scheduled in topological order when possible
URL: https://github.com/apache/flink/pull/10309#discussion_r351104775
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/LazyFromSourcesSchedulingStrategyTest.java
##########
@@ -343,31 +365,9 @@ public void testBlockingANYExecutionStateChange() {
schedulingStrategy.onExecutionStateChange(producer.getId(),
ExecutionState.FINISHED);
}
- assertThat(testingSchedulerOperation,
hasScheduledVertices(consumers));
- }
-
- private static Matcher<TestingSchedulerOperations>
hasScheduledVertices(final List<TestingSchedulingExecutionVertex> consumers) {
-
- final Matcher<Iterable<? extends ExecutionVertexID>>
vertexIdMatcher = containsInAnyOrder(consumers.stream()
Review comment:
I think `assertEquals` is simpler and then we do not need to keep this
Matcher.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
