zhuzhurk commented on a change in pull request #10309: [FLINK-14909][runtime]
Let tasks get scheduled in topological order when possible
URL: https://github.com/apache/flink/pull/10309#discussion_r351113073
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -258,22 +270,32 @@ protected void scheduleOrUpdateConsumersInternal(final
ExecutionVertexID produce
//
------------------------------------------------------------------------
@Override
- public void allocateSlotsAndDeploy(final
Collection<ExecutionVertexDeploymentOption> executionVertexDeploymentOptions) {
+ public void allocateSlotsAndDeploy(final
List<ExecutionVertexDeploymentOption> executionVertexDeploymentOptions) {
validateDeploymentOptions(executionVertexDeploymentOptions);
- final Map<ExecutionVertexID, ExecutionVertexDeploymentOption>
deploymentOptionsByVertex =
-
groupDeploymentOptionsByVertexId(executionVertexDeploymentOptions);
+ final List<ExecutionVertexDeploymentOption>
sortedDeploymentOptions =
Review comment:
The "transition ... to SCHEDULED" log can be in order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
