zhuzhurk commented on a change in pull request #10309: [FLINK-14909][runtime]
Let tasks get scheduled in topological order when possible
URL: https://github.com/apache/flink/pull/10309#discussion_r351115435
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java
##########
@@ -679,4 +708,19 @@ private void startScheduling(final SchedulerNG scheduler)
{
scheduler.setMainThreadExecutor(ComponentMainThreadExecutorServiceAdapter.forMainThread());
scheduler.startScheduling();
}
+
+ private static List<ExecutionVertexID>
getAllExecutionVertexIdsSorted(final JobGraph jobGraph) {
Review comment:
A copy of `deployedExecutionVertices` does not help to verify whether
comparator is invoked and whether the ordered result is respected in
`DefaultScheduler`.
Agreed that we can trust the result of the comparator so we did not test
each possible case but just verifies whether the `deployedExecutionVertices` is
really ordered in the most common case.
`getAllExecutionVertexIdsSorted` is created for code reusability, so that we
do not need to iterate each vertex to generate `ExecutionVertexID`s in a
certain case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
