azagrebin commented on a change in pull request #10339:
[FLINK-14976][cassandra] Release semaphore on all Throwable's in send()
URL: https://github.com/apache/flink/pull/10339#discussion_r351370231
##########
File path:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseTest.java
##########
@@ -296,6 +296,26 @@ public void testReleaseOnSendException() throws Exception
{
}
}
+ @Test(timeout = DEFAULT_TEST_TIMEOUT)
+ public void testReleaseOnSendError() throws Exception {
Review comment:
Just noticed we have now duplicated code in
`testReleaseOnSendException/testReleaseOnSendError`,
`createOpenedSendExceptionTestCassandraSink/createOpenedSendErrorTestCassandraSink
`
and `SendExceptionTestCassandraSink/SendExceptionTestCassandraSink`.
It differs only by type of thrown `Throwable`.
Could you deduplicate it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
