azagrebin commented on a change in pull request #10339:
[FLINK-14976][cassandra] Release semaphore on all Throwable's in send()
URL: https://github.com/apache/flink/pull/10339#discussion_r351815356
##########
File path:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseTest.java
##########
@@ -296,6 +296,26 @@ public void testReleaseOnSendException() throws Exception
{
}
}
+ @Test(timeout = DEFAULT_TEST_TIMEOUT)
+ public void testReleaseOnSendError() throws Exception {
Review comment:
This is close to what I had in mind but the test code could still be
deduplicated.
I added one more
[commit](https://github.com/azagrebin/flink/commit/357dc240469a93b1e3bf0ad8828185aa950731b8)
for that with some code style changes.
I cannot push to your PR, it seems to be disabled. You can review my
suggestion, include it into your PR if you agree and squash the commits, then I
will merge the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
