AHeise commented on a change in pull request #10345: [FLINK-12484][runtime]
synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r351746791
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -384,57 +386,59 @@ protected Counter
setupNumRecordsInCounter(StreamOperator streamOperator) {
}
}
- @Override
- public final void invoke() throws Exception {
+ private void beforeInvoke() throws Exception {
Review comment:
`init()` is probably the right name, but we need to ensure that all
subclasses of `StreamTask` also call `super.init()` if we move the
functionality to it. Similar, we could do enhance `cleanup()` to actually do
all the cleanup and implementators need to invoke that first. That's symmetric
to how you would implement `close()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
