AHeise commented on a change in pull request #10345: [FLINK-12484][runtime]
synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r352364064
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -148,11 +148,7 @@
//
------------------------------------------------------------------------
- /**
- * All interaction with the {@code StreamOperator} must be synchronized
on this lock object to
- * ensure that we don't have concurrent method calls that void
consistent checkpoints.
- */
- private final Object lock = new Object();
+ private final ExecutionDecorator.SynchronizedExecutionDecorator
executionDecorator;
Review comment:
I'd value proper abstraction through interfaces + the ability to inject
dependencies over the separation of concerns. For me, the usage of a concrete
class over an interface, especially on field level, is a big smell.
Btw I don't see any "management" overhead as the lifecycle of the lock is
then bound to the StreamTask.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
