AHeise commented on a change in pull request #10345: [FLINK-12484][runtime]
synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r352365213
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxExecutorImpl.java
##########
@@ -37,9 +39,12 @@
private final int priority;
- public MailboxExecutorImpl(@Nonnull TaskMailbox mailbox, int priority) {
+ public final StreamTaskActionExecutor actionExecutor;
Review comment:
I might have misunderstood the full intent of the ticket, but isn't it the
main idea to simplify the code path of all tasks, which are not legacy sources?
This line introduces a new indirection for executing a mail for _all_ tasks.
I'd rather see two different MailboxExecutor implementations, one for legacy
and one for everything else (=as is). Alternatively, we could also have
decorator around the normal MailboxExecutor that synchronizes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
