xintongsong commented on a change in pull request #10146: 
[FLINK-14188][runtime] TaskExecutor derive and register with default slot 
resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r352428597
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
 ##########
 @@ -155,6 +155,10 @@ public int getPageSize() {
                return pageSize;
        }
 
+       public TaskExecutorResourceSpec getTaskExecutorResourceSpec() {
 
 Review comment:
   Previously we do not have any cases that needs to access this field.
   The public getter is introduced because we need to use it in 
`TaskManagerServices#fromConfiguration` in this commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to