rkhachatryan commented on a change in pull request #10345: [FLINK-12484][runtime] synchronize all mailbox actions URL: https://github.com/apache/flink/pull/10345#discussion_r352523111
########## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxExecutorImplTest.java ########## @@ -73,31 +74,30 @@ public void tearDown() { } @Test - public void testOperations() throws Exception { - final TestRunnable testRunnable = new TestRunnable(); - mailboxExecutor.execute(testRunnable, "testRunnable"); - Assert.assertEquals(testRunnable, mailbox.take(DEFAULT_PRIORITY).getRunnable()); + public void testPutGet() throws Exception { Review comment: Because what actually being tested here is `put` and `get` operations on the `mailbox`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services