rkhachatryan commented on a change in pull request #10345: 
[FLINK-12484][runtime] synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r352369019
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -1486,22 +1486,17 @@ private void handleTimerException(Exception ex) {
        }
 
        private ProcessingTimeCallback deferCallbackToMailbox(MailboxExecutor 
mailboxExecutor, ProcessingTimeCallback callback) {
-               return timestamp -> {
-                       mailboxExecutor.execute(
-                               () -> invokeProcessingTimeCallback(callback, 
timestamp),
-                               "Timer callback for %s @ %d",
-                               callback,
-                               timestamp);
-               };
+               return timestamp ->
+                               mailboxExecutor.execute(() -> {
+                                                       try {
 
 Review comment:
   Not relevant anymore, removed, thanks.
   
   Not sure though, what's more complicated :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to