rkhachatryan commented on a change in pull request #10345:
[FLINK-12484][runtime] synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r352370977
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxExecutorImpl.java
##########
@@ -37,9 +39,12 @@
private final int priority;
- public MailboxExecutorImpl(@Nonnull TaskMailbox mailbox, int priority) {
+ public final StreamTaskActionExecutor actionExecutor;
Review comment:
> Why is this public?
Fixed, thanks.
The intent of this PR is to:
1. make use of mailbox executor safe without the `checkpoint lock`
2. prepare for push `checkpoint lock` down to `SourceStreamTask`
Having a custom mailbox processor in `SourceStreamTask` would still require
to synchronize some actions in `StreamTask`.
As for performance, `actionExecutor` is not used for the hot path, i.e.
`default action`.
(and I'd love to see any data on how such a design (method call stack of
depth 2 instead of 1) affects Flink performance)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
