azagrebin commented on a change in pull request #10397:
[FLINK-15023][core][runtime] Remove on-heap managed memory
URL: https://github.com/apache/flink/pull/10397#discussion_r353237126
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -337,8 +337,7 @@ private static TaskSlotTable createTaskSlotTable(
private static Map<MemoryType, Long> calculateMemorySizeByType(
TaskManagerServicesConfiguration
taskManagerServicesConfiguration) {
final Map<MemoryType, Long> memorySizeByType = new HashMap<>();
- memorySizeByType.put(MemoryType.HEAP,
taskManagerServicesConfiguration.getOnHeapManagedMemorySize().getBytes());
- memorySizeByType.put(MemoryType.OFF_HEAP,
taskManagerServicesConfiguration.getOffHeapManagedMemorySize().getBytes());
+ memorySizeByType.put(MemoryType.OFF_HEAP,
taskManagerServicesConfiguration.getManagedMemorySize().getBytes());
Review comment:
I think we should completely remove
`calculateMemorySizeByType`, `Map<MemoryType, Long> memorySizeByType` and
the second `computeSlotResourceProfile`
in `TaskManagerServices`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
