azagrebin commented on a change in pull request #10397:
[FLINK-15023][core][runtime] Remove on-heap managed memory
URL: https://github.com/apache/flink/pull/10397#discussion_r353201433
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -391,8 +391,7 @@ private static ResourceProfile
computeSlotResourceProfile(int numOfSlots, Map<Me
.setCpuCores(Double.MAX_VALUE)
.setTaskHeapMemory(MemorySize.MAX_VALUE)
.setTaskOffHeapMemory(MemorySize.MAX_VALUE)
- .setOnHeapManagedMemory(new
MemorySize(memorySizeByType.getOrDefault(MemoryType.HEAP, 0L) / numOfSlots))
- .setOffHeapManagedMemory(new
MemorySize(memorySizeByType.getOrDefault(MemoryType.OFF_HEAP, 0L) / numOfSlots))
+ .setManagedMemory(new
MemorySize(memorySizeByType.getOrDefault(MemoryType.OFF_HEAP, 0L) / numOfSlots))
Review comment:
I would put sum of memories for each type in this commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
