azagrebin commented on a change in pull request #10397:
[FLINK-15023][core][runtime] Remove on-heap managed memory
URL: https://github.com/apache/flink/pull/10397#discussion_r353238689
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlot.java
##########
@@ -336,8 +336,7 @@ private void verifyMemoryFreed() {
private static MemoryManager createMemoryManager(ResourceProfile
resourceProfile, int pageSize) {
Map<MemoryType, Long> memorySizeByType = new
EnumMap<>(MemoryType.class);
- memorySizeByType.put(MemoryType.HEAP,
resourceProfile.getOnHeapManagedMemory().getBytes());
- memorySizeByType.put(MemoryType.OFF_HEAP,
resourceProfile.getOffHeapManagedMemory().getBytes());
+ memorySizeByType.put(MemoryType.OFF_HEAP,
resourceProfile.getManagedMemory().getBytes());
Review comment:
```
Map<MemoryType, Long> memorySizeByType =
Collections.singletonMap(MemoryType.OFF_HEAP,
resourceProfile.getManagedMemory().getBytes());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
