zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime]
Introduce data compression to reduce disk and network IO of shuffle.
URL: https://github.com/apache/flink/pull/10375#discussion_r353524158
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java
##########
@@ -217,4 +217,14 @@
* @return self as ByteBuf implementation.
*/
ByteBuf asByteBuf();
+
+ /**
+ * @return whether the buffer is compressed or not.
+ */
+ boolean isCompressed();
+
+ /**
+ * Tags the buffer as compressed or uncompressed.
+ */
+ void setCompressed(boolean isCompressed);
Review comment:
The compression property can be always got before constructing the Buffer
instance I guess, so it is graceful to give that property in the constructor.
So we can remove this interface method and make the internal variable as final.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
