zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime]
Introduce data compression to reduce disk and network IO of shuffle.
URL: https://github.com/apache/flink/pull/10375#discussion_r353530787
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -44,15 +44,15 @@
* {@link PipelinedSubpartitionView#notifyDataAvailable() notify} a read view
created via
* {@link #createReadView(BufferAvailabilityListener)} of new data
availability. Except by calling
* {@link #flush()} explicitly, we always only notify when the first finished
buffer turns up and
- * then, the reader has to drain the buffers via {@link #pollBuffer()} until
its return value shows
- * no more buffers being available. This results in a buffer queue which is
either empty or has an
- * unfinished {@link BufferConsumer} left from which the notifications will
eventually start again.
+ * then, the reader has to drain the buffers via {@link #pollBuffer(boolean)}
until its return value
+ * shows no more buffers being available. This results in a buffer queue which
is either empty or has
+ * an unfinished {@link BufferConsumer} left from which the notifications will
eventually start again.
*
* <p>Explicit calls to {@link #flush()} will force this
* {@link PipelinedSubpartitionView#notifyDataAvailable() notification} for any
* {@link BufferConsumer} present in the queue.
*/
-class PipelinedSubpartition extends ResultSubpartition {
+public class PipelinedSubpartition extends ResultSubpartition {
Review comment:
is it necessary change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
