zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime]
Introduce data compression to reduce disk and network IO of shuffle.
URL: https://github.com/apache/flink/pull/10375#discussion_r353529426
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
##########
@@ -37,11 +40,16 @@
/** The parent partition this subpartition belongs to. */
protected final ResultPartition parent;
+ /** Used to compress buffer to reduce IO. */
+ @Nullable
+ protected final BufferCompressor bufferCompressor;
+
// - Statistics
----------------------------------------------------------
public ResultSubpartition(int index, ResultPartition parent) {
this.index = index;
this.parent = parent;
+ this.bufferCompressor = parent.getBufferCompressor();
Review comment:
Do not need maintain `BufferCompressor` variable inside the
`ResultSubpartition`, because it can be got directly from `parent` for specific
sub partitions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
