Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1255#issuecomment-153905286
Hi @ChengXiangLi, sorry for the long reviewing delay.
The PR is definitely moving in the right direction! I added a couple of
comments in-line. Please let me know if you have questions or would like to
discuss some of the comments.
We will also need a few tests that check the OptimizedPlan that is returned
by the optimizer. We have a few tests in place that check for example that
correct execution strategies are chosen by the optimizer. Since we manually
rewrite the plan, it would be good to have tests that verify our changes, for
example for cases where an operator has multiple outputs of which only one or
all require range partitioning. Please have a look at `PartitionOperatorTest`
and other tests in the `flink-optimizer` module.
Best, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
