StephanEwen commented on issue #10300: [FLINK-14926] [state backends] Make sure 
no resource leak of RocksObject
URL: https://github.com/apache/flink/pull/10300#issuecomment-562599075
 
 
   I think the closing logic on `PredefinedOptions` is not going to work.
   It is an enum and hence a singleton instance. If someone calls close on the 
enum, the resource from some other call to `createColumnOptions()` will be 
disposed. That can even lead to seg faults under concurrency.
   
   The root cause is that objects with life cycle and enums do not go together 
well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to