StephanEwen commented on issue #10300: [FLINK-14926] [state backends] Make sure no resource leak of RocksObject URL: https://github.com/apache/flink/pull/10300#issuecomment-562612612 About the purpose of `PredefinedOptions`: I guess we want this as a default anyways for all cases. We could simply set these always, like the option to create database if missing and to disable WAL. ``` DBOptions .setIncreaseParallelism(4) .setUseFsync(false) .setMaxOpenFiles(-1) .setInfoLogLevel(InfoLogLevel.HEADER_LEVEL) .setStatsDumpPeriodSec(0); ColumnFamilyOptions .setCompactionStyle(CompactionStyle.LEVEL) .setLevelCompactionDynamicLevelBytes(true) ``` The remainder are only in `SPINNING_DISK_OPTIMIZED_HIGH_MEM` and should pretty much be subsumed by the new memory management. In some sense new memory management is the better version of predefined options. Am I overlooking some use cases?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
