StephanEwen commented on issue #10300: [FLINK-14926] [state backends] Make sure 
no resource leak of RocksObject
URL: https://github.com/apache/flink/pull/10300#issuecomment-562600489
 
 
   I think we have three options:
   
     - Have a single the BloomFilter object that lives forever is used across 
RocksDB instances (is that even possible). Is the BloomFilter object large, 
would that be a problem?
   
     - Remove the bloom filter from the predefined options.
   
     - Special case the cleanup of the DB options to search for the BloomFilter 
object and close it.
   
   I think this is a good example why I think we should move away from the 
predefined options in 1.10.
   Having good out of the box values for memory (with the shared per-slot 
cache) and then OptionFactories (that can dispose their values) should make 
PredefinedOptions less needed in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to