pnowojski commented on a change in pull request #10446: [FLINK-15076][task] Fix 
SourceStreamTask cancellation
URL: https://github.com/apache/flink/pull/10446#discussion_r355559140
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
 ##########
 @@ -315,11 +315,11 @@ public void testStateBackendClosingOnFailure() throws 
Exception {
        }
 
        @Test
-       public void testCancellationNotBlockedOnLock() throws Exception {
 
 Review comment:
   Because it was superseded by 
`SourceStreamTaskTest#testCancellationWithSourceBlockedOnLock()`. The previous 
test was hacking some fake `StreamTask` implementation that would be behaving 
exactly as the `SourceStreamTask` (spawning an independent thread, that can 
block).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to