pnowojski commented on a change in pull request #10446: [FLINK-15076][task] Fix
SourceStreamTask cancellation
URL: https://github.com/apache/flink/pull/10446#discussion_r355556063
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxProcessor.java
##########
@@ -195,7 +195,12 @@ public void runMailboxLoop() throws Exception {
public void reportThrowable(Throwable throwable) {
sendControlMail(
() -> {
- throw
WrappingRuntimeException.wrapIfNecessary(throwable);
+ if (throwable instanceof Exception) {
+ throw (Exception) throwable;
+ }
+ else {
+ throw
WrappingRuntimeException.wrapIfNecessary(throwable);
Review comment:
We have to wrap anything that's not an `Exception` (because of
`RunnableWithException`), so we can't NOT wrap `Error`, otherwise code would
not compile?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
