wsry commented on a change in pull request #10492: [FLINK-15140][runtime] Fix 
shuffle data compression doesn't work with BroadcastRecordWriter.
URL: https://github.com/apache/flink/pull/10492#discussion_r355829457
 
 

 ##########
 File path: 
docs/_includes/generated/netty_shuffle_environment_configuration.html
 ##########
 @@ -30,7 +30,7 @@
             
<td><h5>taskmanager.network.pipelined-shuffle.compression.enabled</h5></td>
 
 Review comment:
   Thanks for the review and comments, I agree that we can improve or replace 
the current pipeline compression implement in the future if we have a better 
solution and the change is simple enough (only need to remove several lines of 
code). Besides, the added config option is simple enough and we can keep the 
config option unchanged or map it to new value even when we replace the current 
implementation in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to